linux-kernel - Re: [PATCH] scsi/i2o: restore ioctl changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C35CBA6.10203@kernel.dk>
Date:	Thu, 08 Jul 2010 14:59:18 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Christoph Hellwig <hch@...radead.org>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, John Kacur <jkacur@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi/i2o: restore ioctl changes

On 2010-07-08 14:57, Arnd Bergmann wrote:
> This restores the changes from "scsi/i2o_block: cleanup ioctl
> handling", which accidentally got reverted.
>     
> Origignal changelog:
>       This fixes the ioctl function of the i2o_block driver, which
>       has multiple problems:
>     
>       * The BLKI2OSRSTRAT and BLKI2OSWSTRAT commands always return
>         -ENOTTY on success, where they should return 0.
>       * Support for 32 bit compat is missing
>       * The driver should use the .ioctl function and because
>         .locked_ioctl is going away.
>     
>       The use of the big kernel lock remains for now, but gets
>       made explictit in the ioctl function.
>     
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Jens, this is the commit that went missing due to my broken rebase.
> Please either apply on top of you for-next branch or fold into
> "block: push down BKL into .locked_ioctl", which reverted the change.

Thanks, I just applied this one on top to avoid rebasing things.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/