linux-kernel - Re: [PATCH 03/23] lmb: Print new doubled array location info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201007081255.58049.bjorn.helgaas@hp.com>
Date:	Thu, 8 Jul 2010 12:55:56 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 03/23] lmb: Print new doubled array location info

On Sunday, July 04, 2010 12:56:07 am Yinghai Lu wrote:
> -		pr_info(" %s[0x%x]\t0x%016llx - 0x%016llx, 0x%llx bytes\n",
> -		    name, i, base, base + size - 1, size);
> +		pr_info(" %s[%#x]\t[%#016llx - %#016llx], %#llx bytes\n",
> +		    name, i, base, base + size, size);

I know you think it's prettier to have zeroes and extra spaces like this:

  [0xe7000000 - 0xe8000000, 0x1000000 bytes]

rather than a bunch of 'F's:

  [0xe7000000-0xe7ffffff]

But for the record, I still think you're wrong and that it's better
to be consistent even if it's slightly uglier.  The inconsistencies
lead to confusion and off-by-one errors.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/