linux-kernel - Re: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4C362FA7.807@acm.org>
Date:	Thu, 08 Jul 2010 15:05:59 -0500
From:	Corey Minyard <minyard@....org>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	akpm@...ux-foundation.org,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, sftp.mtuci@...il.com
Subject: Re: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set
 but not used

Looks good to me:

Acked-by: Corey Minyard <cminyard@...sta.com>

On 07/08/2010 02:09 PM, Justin P. Mattock wrote:
> The below patch fixes a warning message generated by GCC, and also
> updates a web address pointing to a pdf containging information.
> CC [M]  drivers/char/ipmi/ipmi_si_intf.o
> drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi':
> drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set but not used
>
> Signed-off-by: Sergey V.<sftp.mtuci@...il.com>
> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c |   10 ++--------
>   1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 094bdc3..7e40d02 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1965,8 +1965,8 @@ static int acpi_gpe_irq_setup(struct smi_info *info)
>
>   /*
>    * Defined at
> - * http://h21007.www2.hp.com/dspp/files/unprotected/devresource/
> - * Docs/TechPapers/IA64/hpspmi.pdf
> + * http://h21007.www2.hp.com/portal/download/files
> + * /unprot/hpspmi.pdf
>    */
>   struct SPMITable {
>   	s8	Signature[4];
> @@ -2013,18 +2013,12 @@ struct SPMITable {
>   static __devinit int try_init_spmi(struct SPMITable *spmi)
>   {
>   	struct smi_info  *info;
> -	u8 		 addr_space;
>
>   	if (spmi->IPMIlegacy != 1) {
>   		printk(KERN_INFO PFX "Bad SPMI legacy %d\n", spmi->IPMIlegacy);
>   		return -ENODEV;
>   	}
>
> -	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
> -		addr_space = IPMI_MEM_ADDR_SPACE;
> -	else
> -		addr_space = IPMI_IO_ADDR_SPACE;
> -
>   	info = kzalloc(sizeof(*info), GFP_KERNEL);
>   	if (!info) {
>   		printk(KERN_ERR PFX "Could not allocate SI data (3)\n");
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/