linux-kernel - Re: [PATCH 13/18] ima: use generic_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1007090852200.23354@tundra.namei.org>
Date:	Fri, 9 Jul 2010 08:52:47 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	John Kacur <jkacur@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Christoph Hellwig <hch@....de>, Mimi Zohar <zohar@...ibm.com>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs

On Thu, 8 Jul 2010, Mimi Zohar wrote:

> On Thu, 2010-07-08 at 15:00 +0200, Arnd Bergmann wrote:
> > On Thursday 08 July 2010, Mimi Zohar wrote:
> > > On Wed, 2010-07-07 at 23:40 +0200, Arnd Bergmann wrote:
> > > > The default for llseek will change to no_llseek,
> > > > so securityfs users need to add explicit .llseek
> > > > assignments. Since we're dealing with regular
> > > > files from a VFS perspective, use generic_file_llseek.
> > > 
> > > As both the 'violations' and 'runtime_measurement_counts' are single
> > > values and 'policy' doesn't support read, this patch doesn't hurt, but
> > > adding .llseek is probably unnecessary.
> > 
> > Ok, thanks for the confirmation.
> > 
> > Are you applying the patch in your tree, or should I keep it in my
> > series?
> 
> I'll leave that up to James.

I can take the patches, depends on what Arnd thinks is best.

> 
> > Note that while it may not be necessary to add these specific .llseek
> > operations, the reason I'm doing it is because I want to provably
> > have a .llseek operation in every file_operation in the kernel before
> > the default gets changed.
> > 
> > 	Arnd
> 
> Thanks for the clarification.
> 
> Mimi
> 

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/