linux-kernel - Re: [PATCH] fujitsu-laptop: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201007082307.o68N71vX031390@turbo.physics.adelaide.edu.au>
Date:	Fri, 9 Jul 2010 08:37:01 +0930 (CST)
From:	Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>
To:	axel.lin@...il.com (Axel Lin)
Cc:	linux-kernel@...r.kernel.org (linux-kernel),
	jwoithe@...sics.adelaide.edu.au (Jonathan Woithe),
	mjg@...hat.com (Matthew Garrett),
	akpm@...ux-foundation.org (Andrew Morton),
	stefani@...bold.net (Stefani Seibold),
	ak@...ux.intel.com (Andi Kleen),
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] fujitsu-laptop: make needlessly global symbols static

Looks fine to me.

Acked-by: Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>

> The following symbols are needlessly defined global:
> 
> logolamp_led
> kblamps_led
> 
> This patch makes the symbols static.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/platform/x86/fujitsu-laptop.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index e325aeb..a758d59 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -182,7 +182,7 @@ static enum led_brightness logolamp_get(struct led_classdev *cdev);
>  static void logolamp_set(struct led_classdev *cdev,
>  			       enum led_brightness brightness);
>  
> -struct led_classdev logolamp_led = {
> +static struct led_classdev logolamp_led = {
>   .name = "fujitsu::logolamp",
>   .brightness_get = logolamp_get,
>   .brightness_set = logolamp_set
> @@ -192,7 +192,7 @@ static enum led_brightness kblamps_get(struct led_classdev *cdev);
>  static void kblamps_set(struct led_classdev *cdev,
>  			       enum led_brightness brightness);
>  
> -struct led_classdev kblamps_led = {
> +static struct led_classdev kblamps_led = {
>   .name = "fujitsu::kblamps",
>   .brightness_get = kblamps_get,
>   .brightness_set = kblamps_set
> -- 
> 1.5.4.3
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/