linux-kernel - Re: [PATCH] asus-laptop: return proper error for store_ledd if write_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 8 Jul 2010 09:50:43 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg@...hat.com>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] asus-laptop: return proper error for store_ledd if 
	write_acpi_int fail

On Thu, Jul 8, 2010 at 7:55 AM, Axel Lin <axel.lin@...il.com> wrote:
> In current implementation, store_ledd() does not return error if write_acpi_int
> fail.
> This patch fixes it by return -ENODEV if write_acpi_int fail.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/platform/x86/asus-laptop.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 93487eb..975751d 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -796,10 +796,11 @@ static ssize_t store_ledd(struct device *dev, struct device_attribute *attr,
>
>        rv = parse_arg(buf, count, &value);
>        if (rv > 0) {
> -               if (write_acpi_int(asus->handle, METHOD_LEDD, value))
> +               if (write_acpi_int(asus->handle, METHOD_LEDD, value)) {
>                        pr_warning("LED display write failed\n");
> -               else
> -                       asus->ledd_status = (u32) value;
> +                       return -ENODEV;
> +               }
> +               asus->ledd_status = (u32) value;
>        }
>        return rv;
>  }
> --
> 1.5.4.3
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Thanks !

Acked-by: Corentin Chary <corentincj@...aif.net>
-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/