linux-kernel - Re: [PATCH] msi-wmi: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100708103442.28520f6f@destiny.ordissimo>
Date:	Thu, 8 Jul 2010 10:34:42 +0200
From:	Anisse Astier <anisse@...ier.eu>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg@...hat.com>,
	Thomas Renninger <trenn@...e.de>,
	Richard Purdie <rpurdie@...ux.intel.com>,
	Carlos Corbacho <carlos@...angeworlds.co.uk>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] msi-wmi: make needlessly global symbols static

Hi Axel,

On Thu, 08 Jul 2010 09:50:30 +0800, Axel Lin <axel.lin@...il.com> wrote :

> backlight is needlessly defined global.
> This patch makes the symbol static.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
Acked-by: Anisse Astier <anisse@...ier.eu>

Thanks,

Anisse

> ---
>  drivers/platform/x86/msi-wmi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
> index d173600..42a5469 100644
> --- a/drivers/platform/x86/msi-wmi.c
> +++ b/drivers/platform/x86/msi-wmi.c
> @@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
>  };
>  static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
>  
> -struct backlight_device *backlight;
> +static struct backlight_device *backlight;
>  
>  static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/