linux-kernel - Re: [PATCH] msi-laptop: make struct rfkill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 09 Jul 2010 04:24:38 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<greg@...ah.com>
Cc:	<mzxreary@...inter.de>, <axel.lin@...il.com>,
	<rpurdie@...ux.intel.com>, <mjg@...hat.com>, <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] msi-laptop: make struct rfkill_ops const

Hi Greg, 

於 四，2010-07-08 於 11:39 -0700，Greg KH 提到：
> On Thu, Jul 08, 2010 at 11:53:15AM -0600, Joey Lee wrote:
> > Hi Axel, 
> > 
> > 於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> > > rfkill uses a const struct rfkill_ops pointer.
> > > 
> > > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > > ---
> > >  drivers/platform/x86/msi-laptop.c |    6 +++---
> > >  1 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> > > index afd762b..05634f8 100644
> > > --- a/drivers/platform/x86/msi-laptop.c
> > > +++ b/drivers/platform/x86/msi-laptop.c
> > > @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> > >  	return 0;
> > >  }
> > >  
> > > -static struct rfkill_ops rfkill_bluetooth_ops = {
> > > +static const struct rfkill_ops rfkill_bluetooth_ops = {
> > >  	.set_block = rfkill_bluetooth_set
> > >  };
> > >  
> > > -static struct rfkill_ops rfkill_wlan_ops = {
> > > +static const struct rfkill_ops rfkill_wlan_ops = {
> > >  	.set_block = rfkill_wlan_set
> > >  };
> > >  
> > > -static struct rfkill_ops rfkill_threeg_ops = {
> > > +static const struct rfkill_ops rfkill_threeg_ops = {
> > >  	.set_block = rfkill_threeg_set
> > >  };
> > >  
> > 
> > The patch good to me, do I need Signed-off it?
> > How can I signed off a patch?
> 
> You can say:
> 	Signed-off-by: your name <your_email>
> 
> and then Matthew will add it.
> 
> Or you can take the original patch, add your signed-off-by, and resend
> it to Matthew keeping the correct authorship information there by making
> sure the first line in the body of the email has:
> 	From: Original author <email>
> 
> so git will get it right.
> 
> hope this helps,

Thank's for your kindly teach, it's useful to a rookie. :-)

Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/