lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Jul 2010 18:01:37 -0700 (PDT) From: Roland McGrath <roland@...hat.com> To: paulmck@...ux.vnet.ibm.com Cc: Oleg Nesterov <oleg@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Don Zickus <dzickus@...hat.com>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...e.hu>, Jerome Marchand <jmarchan@...hat.com>, Mandeep Singh Baines <msb@...gle.com>, linux-kernel@...r.kernel.org, stable@...nel.org, "Eric W. Biederman" <ebiederm@...ssion.com> Subject: Re: while_each_thread() under rcu_read_lock() is broken? > Hmmm... The kerneldoc for rcu_read_lock() looks like it says this > pretty unambiguously. Then again, that is easy for me to say, given > that I was the one who made most of this stuff up. ;-) Yeah, well, I thought I knew what rcu_read_lock did and the only new thing I had in mind was using call_rcu, so that's the only place I looked. It wasn't entirely unreasonable to have to read through Documentation/RCU/ a bit for a subtlety of this kind, and I did find it quickly enough once Oleg's attentiveness alerted me to be freshly afraid of the subtleties. > But it has been awhile since I looked after the kerneldoc. Please see > below for the changes I would make if left to myself. Those look good to me! > Any other suggestions for improvement to the kerneldoc? Oh, I don't know, send over someone to read it to me in a sultry voice so I get appropriately motivated to cast about for all of it I can find and listen closely to every word? It already looks like if I'd actually read all of it twice that day, I would have had the information I needed. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists