linux-kernel - [patch] 9p: strlen() doesn't count the terminator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100710095154.GU19184@bicker>
Date:	Sat, 10 Jul 2010 11:51:54 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Eric Van Hensbergen <ericvh@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Abhishek Kulkarni <adkulkar@...il.iu.edu>,
	Venkateswararao Jujjuri <jvrao@...ibm.com>,
	linux-kernel@...r.kernel.org,
	Tilman Sauerbeck <tilman@...e-monkey.de>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [patch] 9p: strlen() doesn't count the terminator

This is an off by one bug because strlen() doesn't count the NULL
terminator.  We strcpy() addr into a fixed length array of size
UNIX_PATH_MAX later on.

The addr variable is the name of the device being mounted.

CC: stable@...nel.org
Signed-off-by: Dan Carpenter <error27@...il.com>

diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 98ce9bc..c85109d 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args)
 
 	csocket = NULL;
 
-	if (strlen(addr) > UNIX_PATH_MAX) {
+	if (strlen(addr) >= UNIX_PATH_MAX) {
 		P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n",
 			addr);
 		return -ENAMETOOLONG;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/