linux-kernel - Re: [PATCH v2] x86: Early-boot serial I/O support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100710213211.GD6615@lenovo>
Date:	Sun, 11 Jul 2010 01:32:11 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>, Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH v2] x86: Early-boot serial I/O support

On Sun, Jul 11, 2010 at 12:18:06AM +0300, Pekka Enberg wrote:
> On Sun, Jul 11, 2010 at 12:07 AM, Cyrill Gorcunov <gorcunov@...il.com> wrote:
> >> @@ -203,6 +205,17 @@ static inline int isdigit(int ch)
> >>       return (ch >= '0') && (ch <= '9');
> >>  }
> >>
> >> +static inline int isxdigit(int ch)
> >> +{
> >> +     if (isdigit(ch))
> >> +             return true;
> >> +
> >> +     if ((ch >= 'a') && (ch <= 'f'))
> >> +             return true;
> >> +
> >> +     return (ch >= 'A') && (ch <= 'F');
> >> +}
> >> +
> >
> > I suspect it's supposed to be static inline *bool*, right?
> 
> Yes, but I followed 'isdigit' here for symmetry and it uses 'int'.
> 
>                        Pekka
> 

ok, I see

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/