linux-kernel - Re: [PATCH] Drivers: isdn: Fixed warnings and odd code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100710214156.GA15902@merkur.ravnborg.org>
Date:	Sat, 10 Jul 2010 23:41:56 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Zachary Richey <zr.public@...il.com>
Cc:	isdn@...ux-pingi.de, tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: isdn: Fixed warnings and odd code.

On Sat, Jul 10, 2010 at 05:27:29PM -0400, Zachary Richey wrote:
> This patch fixes compile time warnings in drivers/isdn/sc/init.c, and
> also cleans up what looked like redundant code in this file.

>  	outb(PRI_BASEPG_VAL, pgport);

Here we request Primary rate interface - see "PRI"

>  	msleep_interruptible(1000);
> -	sig = readl(rambase + SIG_OFFSET);
> +	sig = readl(&rambase + SIG_OFFSET);
>  	pr_debug("Looking for a signature, got 0x%lx\n", sig);
> -	if(sig == SIGNATURE)
> +	if (sig == SIGNATURE)
>  		return PRI_BOARD;
> -
> -	/*
> -	 * Try to identify a PRI card
> -	 */
> -	outb(BRI_BASEPG_VAL, pgport);

Here we request Basic rate interface - see "BRI".

So this is not redundant code and you cannot delete it.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/