linux-kernel - Re: [PATCH -V14 0/11] Generic name to handle and open by handle syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r5jcc4qq.fsf@linux.vnet.ibm.com>
Date:	Sat, 10 Jul 2010 10:28:37 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Andreas Dilger <adilger@...ger.ca>, Neil Brown <neilb@...e.de>
Cc:	"J. Bruce Fields" <bfields@...ldses.org>,
	Miklos Szeredi <miklos@...redi.hu>,
	Dave Chinner <david@...morbit.com>,
	Christoph Hellwig <hch@...radead.org>,
	"viro\@zeniv.linux.org.uk Viro" <viro@...iv.linux.org.uk>,
	"corbet\@lwn.net Corbet" <corbet@....net>,
	"hooanon05\@yahoo.co.jp Okajima" <hooanon05@...oo.co.jp>,
	linux-fsdevel@...r.kernel.org,
	"sfrench\@us.ibm.com French" <sfrench@...ibm.com>,
	"philippe.deniel\@CEA.FR Deniel" <philippe.deniel@....FR>,
	"linux-kernel\@vger.kernel.org Mailinglist" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -V14 0/11] Generic name to handle and open by handle syscalls

On Fri, 9 Jul 2010 12:42:42 -0600, Andreas Dilger <adilger@...ger.ca> wrote:
> On 2010-07-08, at 06:21, Neil Brown wrote:
> > On Thu, 08 Jul 2010 16:10:09 +0530
> > "Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com> wrote:
> >> How about adding mnt_id to the handle ? Documentation file says it is unique 
> >> 
> >> (1) mount ID:  unique identifier of the mount (may be reused after umount)
> 
> But this value is not persistent across a reboot, or even an
> umount/mount so it is not useful as an identifier.


mount id should not be looked at as a persistent identifier. It should
be used to derive a persistent identifier from /proc/self/mountinfo. The
persistent identifier could be the combination of device properties,
file system properties or the uuid which is going to be an optional
tag in /proc/self/mountinfo. 

This also implies we need to hold a reference in the mount to make sure
we can safely lookup uuid using mount id.

> 
> I suppose one way to resolve this issue is to just allow the
> underlying filesystem to supply a completely opaque filehandle to
> userspace.  For local filesystems that don't care about persistence or
> uniqueness between nodes they can use something like mount_id, and for
> distributed/clustered filesystems they can include a globally-unique
> identifier.


We could use mountid to get the persistent id from mountinfo right ? So
file handle request would include

fd = open(name);
file_handle = fd_to_handle(fd);
fs_uuid = get_uuid(file_handle.mnt_id);
close(fd);

So for your usecase the handle send to other nodes include will include
cluster_fs_uuid and file_identifier. 

-aneesh


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/