linux-kernel - Re: [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100711211547.GA24666@ericsson.com>
Date:	Sun, 11 Jul 2010 14:15:47 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Joe Perches <joe@...ches.com>
CC:	Jean Delvare <khali@...ux-fr.org>,
	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Hans de Goede <hdegoede@...hat.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paul Goyette <paul@...oppee.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add strict test of logical test
 continuations at beginning of line

On Sun, Jul 11, 2010 at 03:52:59PM -0400, Joe Perches wrote:
> On Sun, 2010-07-11 at 21:34 +0200, Jean Delvare wrote:
> > On Sun, 11 Jul 2010 11:57:12 -0700, Joe Perches wrote:
> > > I don't remember that discussion.  Link?
> > http://lkml.org/lkml/2009/12/5/65
> > You started the thread, so I would think you'd remember it.
> 
> Though there are differences in opinion about what's important,
> I try to forget the trivial.  Just ask my sweet wife...
> 
Same issue hit me twice now, so it isn't as if nobody cares. 

For my part, I don't care where to put the &&. But I would like to have a means 
to get beyond the basic stuff before submitting my patches, to give reviewers 
an opportunity to find the _real_ problems in my code.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/