linux-kernel - Re: [PATCH & RESEND] avoid NULL deference in ext2_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 11 Jul 2010 16:31:35 +0800
From:	shenghui <crosslonelyover@...il.com>
To:	kernel-janitors <kernel-janitors@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	error27 <error27@...il.com>
Subject: Re: [PATCH & RESEND] avoid NULL deference in ext2_xattr_get

2010/7/11 crosslonelyover <crosslonelyover@...il.com>:
> Hi Dan Carpenter,
>
>     Thanks for your instructions. I regenerated the patch.
> Please check it.
>
> From 3149865e0d118b939c27659a4e4c884eaa6b3a4c Mon Sep 17 00:00:00 2001
> From: Wang Sheng-Hui <crosslonelyover@...il.com>
> Date: Sat, 10 Jul 2010 22:07:37 -0400
> Subject: [PATCH] avoid NULL deference in ext2_xattr_get
>
>
> Signed-off-by: Wang Sheng-Hui <crosslonelyover@...il.com>
> ---
>  fs/ext2/xattr.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 7c39157..81ec1c6 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -156,11 +156,12 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name,
>        char *end;
>        int error;
>
> +       if (name == NULL)
> +               return -EINVAL;
> +
>        ea_idebug(inode, "name=%d.%s, buffer=%p, buffer_size=%ld",
>                  name_index, name, buffer, (long)buffer_size);
>
> -       if (name == NULL)
> -               return -EINVAL;
>        down_read(&EXT2_I(inode)->xattr_sem);
>        error = -ENODATA;
>        if (!EXT2_I(inode)->i_file_acl)
> --
> 1.7.1.1
>
>
>

Please ignore this patch. Just for gmail format check.
Thanks for David Beal's explanation!

-- 


Thanks and Best Regards,
shenghui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/