linux-kernel - Re: [PATCH] remove mmu notifier calls in apply_to_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1007121343510.21432@kaball-desktop>
Date:	Mon, 12 Jul 2010 13:50:41 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] remove mmu notifier calls in apply_to_page_range

On Fri, 9 Jul 2010, Jeremy Fitzhardinge wrote:
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> Cc: Andrea Arcangeli <aarcange@...hat.com>
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 6ab19dd..d6b89eb 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1890,7 +1890,6 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
>  	int err;
>  
>  	BUG_ON(addr >= end);
> -	mmu_notifier_invalidate_range_start(mm, start, end);
>  	pgd = pgd_offset(mm, addr);
>  	do {
>  		next = pgd_addr_end(addr, end);
> @@ -1898,7 +1897,7 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
>  		if (err)
>  			break;
>  	} while (pgd++, addr = next, addr != end);
> -	mmu_notifier_invalidate_range_end(mm, start, end);
> +
>  	return err;
>  }
>  EXPORT_SYMBOL_GPL(apply_to_page_range);
> 
> 
> 

The local variable start in apply_to_page_range is not used anymore:
remove it.

Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>

---

diff --git a/mm/memory.c b/mm/memory.c
index 9d33bfe..0a47927 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1989,7 +1989,7 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
 {
 	pgd_t *pgd;
 	unsigned long next;
-	unsigned long start = addr, end = addr + size;
+	unsigned long end = addr + size;
 	int err;
 
 	BUG_ON(addr >= end);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/