linux-kernel - Re: [PATCHv9 2.6.35-rc4-tip 10/13] perf: Re-Add make_absolute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jul 2010 21:03:57 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Mark Wielaard <mjw@...hat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Naren A Devaiah <naren.devaiah@...ibm.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCHv9 2.6.35-rc4-tip 10/13]  perf: Re-Add make_absolute_path

* Arnaldo Carvalho de Melo <acme@...radead.org> [2010-07-12 11:00:23]:

> Em Mon, Jul 12, 2010 at 04:04:12PM +0530, Srikar Dronamraju escreveu:
> > perf: Re-Add make_absolute_path
> > 
> > perf probe for uprobes would use make_absolute_path.
> > make_absolute_path can be used to convert a file name to a dso name.
> > 
> > so if user specifies the function to be traced as malloc@...b/libc.so.6
> > it needs to be converted to malloc@...c-2.5.so
> 
> Isn't this the other way around? I.e. "if the user specifies
> malloc@...c-2.5.so it needs to be converted to malloc@...b/libc.so.6"?
> 

Actually we dont need to convert malloc@...c-2.5.so to a
malloc@...b/libc.so.6. Because we can match the shortname of the dso. 

Problem will occur when users specifies a full path of the file.
Since the file can refer to a symbolic link and the dso will have just
the short name or the target file name. Here I am using
make_absolute_path to resolve to the target file.
Now we can then either check on dso full names or short names.
I have chosen to use the short name.


> Also please remove the xstrdup and die calls from this function, we're
> trying to get rid of all such 'panic' like functions so that we can
> librarize as much code as possible.

Okay, Can I do that in subsequent versions of the patchset?

--
Thanks and Regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/