linux-kernel - Re: [PATCH] Staging: line6: fix leaks in line6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Jul 2010 18:19:16 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	kernel-janitors@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Frederik Deweerdt <frederik.deweerdt@...og.eu>,
	Tejun Heo <tj@...nel.org>, Stoyan Gaydarov <sgayda2@...c.edu>,
	Németh Márton <nm127@...email.hu>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: line6: fix leaks in line6_probe()

On Mon, Jul 12, 2010 at 06:47:30PM +0400, Kulikov Vasiliy wrote:
> -	if (ret < 0) {
> -		line6_destruct(interface);
> -		return ret;
> -	}
> +	if (ret < 0)
> +		goto err_put;

This should be:
		goto err_destruct;

regards,
dan carpenter

>  
>  	dev_info(&interface->dev, "Line6 %s now attached\n",
>  		 line6->properties->name);
>  	line6_devices[devnum] = line6;
>  	line6_list_devices();
> +	return 0;
> +
> +err_destruct:
> +	line6_destruct(interface);
> +err_put:
> +	usb_put_intf(interface);
> +	usb_put_dev(usbdev);
>  	return ret;
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/