linux-kernel - Re: [PATCH -V16 02/12] vfs: Add name to file handle conversion support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1OYM1q-0006wn-Rn@pomaz-ex.szeredi.hu>
Date:	Mon, 12 Jul 2010 18:38:50 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	miklos@...redi.hu, hch@...radead.org, viro@...iv.linux.org.uk,
	adilger@....com, corbet@....net, neilb@...e.de, npiggin@...e.de,
	hooanon05@...oo.co.jp, bfields@...ldses.org,
	linux-fsdevel@...r.kernel.org, sfrench@...ibm.com,
	philippe.deniel@....FR, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -V16 02/12] vfs: Add name to file handle conversion support

On Mon, 12 Jul 2010, Aneesh Kumar K. V wrote:
> That would include another stat call on the file to get the st_dev ? As
> per the last review (Message-id:20100708082143.3701bfc7@...abene.brown)
> http://article.gmane.org/gmane.linux.kernel/1007385 we discussed that
> it would be nice to add st_dev as a part of handle. Later I suggested
> it would be nice to get mount_id instead of st_dev because st_dev is
> not stable (against remounts) for file system that doesn't have a
> backing device. So instead of using something that is partially stable,
> add mnt_id which is explicitly stated to be unstable across remounts.
> 
> If you are against having mount_id as a part of struct file_handle, do
> you think we could add it as a extra argument to syscall ? 

Yeah, I think that would be cleaner.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/