linux-kernel - Re: [PATCH -V16 07/12] vfs: Support null pathname in linkat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1OYMRK-00070W-Qn@pomaz-ex.szeredi.hu>
Date:	Mon, 12 Jul 2010 19:05:10 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	miklos@...redi.hu, hch@...radead.org, viro@...iv.linux.org.uk,
	adilger@....com, corbet@....net, neilb@...e.de, npiggin@...e.de,
	hooanon05@...oo.co.jp, bfields@...ldses.org,
	linux-fsdevel@...r.kernel.org, sfrench@...ibm.com,
	philippe.deniel@....FR, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -V16 07/12] vfs: Support null pathname in linkat

On Mon, 12 Jul 2010, Aneesh Kumar K. V wrote:
> /*
>  * Return -ENOENT if we've raced with unlink and i_nlink is 0.  Doing
>  * otherwise has the potential to corrupt the orphan inode list.
>  */
> if (inode->i_nlink == 0)
> 	return -ENOENT;
> 
> I can move this check to VFS so that we do it for all file systems. 

That makes sense.  Hopefully filesystems which implement hard links
will change i_nlink to zero for the last unlink...

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/