linux-kernel - Re: [PATCH 01/12] staging: autoconvert trivial BKL users to private mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jul 2010 13:46:53 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Martyn Welch <martyn.welch@...com>
Cc:	linux-kernel@...r.kernel.org, John Kacur <jkacur@...hat.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>, devel@...verdev.osuosl.org
Subject: Re: [PATCH 01/12] staging: autoconvert trivial BKL users to private mutex

On Tuesday 13 July 2010, Martyn Welch wrote:

> > -     lock_kernel();
> > +     mutex_lock(&vme_user_mutex);
> >       ret = vme_user_ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
> > -     unlock_kernel();
> > +     mutex_unlock(&vme_user_mutex);
> >   
> 
> Wha!, where'd that come from!!??
> 
> Ah, OK - "Staging: push down BKL into ioctl functions", missed that,
> looks fine.
> <http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=b1f2ac07636aadee5cb077fc7e830908b00fcaae>
> 

Both patches only did blind conversions to drive the BKL out. Feel free to
kill off that mutex and the vme_user_unlocked_ioctl() function in there again
if you are convinced that no locking is actually needed in there.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/