linux-kernel - [RESEND][RFC][PATCH] fsnotify: track all events on filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jul 2010 17:36:26 +0200 (CEST)
From:	jakob.goldbach@...il.com (Jakob Goldbach)
To:	linux-kernel@...r.kernel.org
Cc:	eparis@...hat.com
Subject: [RESEND][RFC][PATCH] fsnotify: track all events on filesystem

(Resending, this time with fsnotify maintainer cc'ed)

This patch allows notification groups to get events on the entire filesystem,
not just on registered inodes.

I want to use it for a notification group that tracks all changes to the 
filesystem in order to do faster backups.

Is this a good or bad idea? 

/Jakob


diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c
index fcc2f06..aa9e204 100644
--- a/fs/notify/fsnotify.c
+++ b/fs/notify/fsnotify.c
@@ -147,7 +147,9 @@ void fsnotify(struct inode *to_tell, __u32 mask, void *data, int data_is, const
 	if (!(test_mask & fsnotify_mask))
 		return;
 
-	if (!(test_mask & to_tell->i_fsnotify_mask))
+	if (!
+	    (test_mask &
+	     (to_tell->i_fsnotify_mask | to_tell->i_sb->s_fsnotify_mask)))
 		return;
 	/*
 	 * SRCU!!  the groups list is very very much read only and the path is
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 68ca1b0..102acf5 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1382,6 +1382,9 @@ struct super_block {
 	 * generic_show_options()
 	 */
 	char *s_options;
+#ifdef CONFIG_FSNOTIFY
+	__u32			s_fsnotify_mask;
+#endif
 };
 
 extern struct timespec current_fs_time(struct super_block *sb);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/