linux-kernel - Re: [PATCH] slob_free:free objects to their own list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikMcPcldBh_uVKxrH7rEIUju3Y_3X2jLi9jw2Vs@mail.gmail.com>
Date:	Tue, 13 Jul 2010 20:52:04 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Bob Liu <lliubbo@...il.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org, mpm@...enic.com,
	hannes@...xchg.org, LKML <linux-kernel@...r.kernel.org>,
	Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH] slob_free:free objects to their own list

Hi Bob,

[ Please CC me on SLOB patches. You can use the 'scripts/get_maintainer.pl'
  script to figure out automatically who to CC on your patches. ]

On Sat, Jul 10, 2010 at 1:05 PM, Bob Liu <lliubbo@...il.com> wrote:
> slob has alloced smaller objects from their own list in reduce
> overall external fragmentation and increase repeatability,
> free to their own list also.
>
> Signed-off-by: Bob Liu <lliubbo@...il.com>

The patch looks sane to me. Matt, does it look OK to you as well?

It would be nice to have some fragmentation numbers for this. One
really simple test case is to grep for MemTotal and MemFree in
/proc/meminfo. I'd expect to see some small improvement with your
patch applied. Quantifying long term fragmentation would be even
better but I don't have a good test case for that so I'm CC'ing Mel.

> ---
>  mm/slob.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/mm/slob.c b/mm/slob.c
> index 3f19a34..d582171 100644
> --- a/mm/slob.c
> +++ b/mm/slob.c
> @@ -396,6 +396,7 @@ static void slob_free(void *block, int size)
>        slob_t *prev, *next, *b = (slob_t *)block;
>        slobidx_t units;
>        unsigned long flags;
> +       struct list_head *slob_list;
>
>        if (unlikely(ZERO_OR_NULL_PTR(block)))
>                return;
> @@ -424,7 +425,13 @@ static void slob_free(void *block, int size)
>                set_slob(b, units,
>                        (void *)((unsigned long)(b +
>                                        SLOB_UNITS(PAGE_SIZE)) & PAGE_MASK));
> -               set_slob_page_free(sp, &free_slob_small);
> +               if (size < SLOB_BREAK1)
> +                       slob_list = &free_slob_small;
> +               else if (size < SLOB_BREAK2)
> +                       slob_list = &free_slob_medium;
> +               else
> +                       slob_list = &free_slob_large;
> +               set_slob_page_free(sp, slob_list);
>                goto out;
>        }
>
> --
> 1.5.6.3
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/