linux-kernel - Re: [PATCH] workqueue: fix locking in retry path of maybe_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C3D8570.4080902@kernel.org>
Date:	Wed, 14 Jul 2010 11:37:52 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Yong Zhang <yong.zhang@...driver.com>
CC:	torvalds@...ux-foundation.org, mingo@...e.hu,
	linux-kernel@...r.kernel.org, jeff@...zik.org,
	akpm@...ux-foundation.org, rusty@...tcorp.com.au,
	cl@...ux-foundation.org, dhowells@...hat.com,
	arjan@...ux.intel.com, oleg@...hat.com, axboe@...nel.dk,
	fweisbec@...il.com, dwalker@...eaurora.org,
	stefanr@...6.in-berlin.de, florian@...kler.org,
	andi@...stfloor.org, mst@...hat.com, randy.dunlap@...cle.com
Subject: Re: [PATCH] workqueue: fix locking in retry path of maybe_create_worker()

On 07/12/2010 03:23 PM, Yong Zhang wrote:
> On Mon, Jul 12, 2010 at 10:53:18AM +0200, Tejun Heo wrote:
>> maybe_create_worker() mismanaged locking when worker creation fails
>> and it has to retry.  Fix locking and simplify lock manipulation.
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Reported-by: Yong Zhang <yong.zhang@...driver.com>
>> ---
>> Heh, that was stupid.  Thanks a lot for spotting it.  I simplified
>> things a bit there as there's no reason to repeatedly lock and unlock
>> there.  Does this look good to you?
> 
> Yeah, this is better.

Pushed out to for-next-candidate branch.

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next-candidate

I'll push it to linux-next the next week.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/