linux-kernel - Re: [PATCH] wm8727: add a missing return in wm8727_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Jul 2010 15:59:57 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Tejun Heo <tj@...nel.org>, Neil Jones <neil.jones@...tec.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] wm8727: add a missing return in wm8727_platform_probe

On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
> otherwise the error path will always be executed.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/codecs/wm8727.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c
> index 1072621..9d1df26 100644
> --- a/sound/soc/codecs/wm8727.c
> +++ b/sound/soc/codecs/wm8727.c
> @@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
>  		goto err_codec;
>  	}
>  
> +	return 0;
> +
>  err_codec:
>  	snd_soc_unregister_codec(codec);
>  err:

Both

Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/