linux-kernel - Re: Request to submit driver for Nuvoton TPM I2C device (WPCT301)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100714082531.d1e6d035.randy.dunlap@oracle.com>
Date:	Wed, 14 Jul 2010 08:25:31 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Marcel Selhorst <m.selhorst@...rix.com>
Cc:	"Dan.Morav@...oton.com" <Dan.Morav@...oton.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"debora@...ux.vnet.ibm.com" <debora@...ux.vnet.ibm.com>,
	"srajiv@...ux.vnet.ibm.co" <srajiv@...ux.vnet.ibm.co>,
	"Michal.Schramm@...oton.com" <Michal.Schramm@...oton.com>
Subject: Re: Request to submit driver for Nuvoton TPM I2C device (WPCT301)

On Wed, 14 Jul 2010 12:57:20 +0200 Marcel Selhorst wrote:

> Hi Dan,
> 
> thanks for the driver. When submitting the patch, could you please add some
> information, where / on what platforms this chip can be found?
> 
> Also, could you please rename your driver to tpm_nuvoton_i2c.c (or
> similar)? There are other I2C-TPM device drivers from other vendors
> currently in the process of being included and we need to distinguish
> between these.
> 
> I had a very quick look over your code, could you please put your #defines
> on top of the file? And please provide a complete patch (including KConfig
> / Makefile) against Linux instead of sending individual files.


It should also be submitted as a patch to the current kernel.
This matters for the Kconfig / Makefile changes.


> Thanks,
> Marcel
> 
> Am 14.07.2010 11:31, schrieb Dan.Morav@...oton.com:
> > Hello,
> > 
> > I'd like to submit a new TPM driver.
> > 
> > Attached is a new driver for Nuvoton TPM with I2C interface.
> > - tpm_i2c.c is the driver code
> > - tpm.h and Makefile are added only for reference and stand alone compilation
> > 
> > The driver should be part of the drivers/char/tpm.
> > The driver uses standard Linux I2C bus driver interface to access the I2C bus.
> > The driver uses standard Linux TPM driver API.
> > The driver was tested on Linux kernel v2.6.31.
> > 
> > Please advice if any further information is required.
> > 
> > Regards,
> > Dan.
> > _________________________
> > Dan Morav
> > Advanced PC
> > Nuvoton Technology Israel Ltd.
> > Office +972.9.970.2388
> > eMail: dan.morav@...oton.com
> > 
> > 
> > ===========================================================================================
> > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> > 
> > ===========================================================================================
> > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
> 
> -- 
> Sirrix AG security technologies -- http://www.sirrix.com
> Dipl.-Ing. Marcel Selhorst  eMail: m.selhorst@...rix.com
> Tel: +49 (234) 610071-126   Fax: +49 (234) 610071-526
> Tel: +49 (681)  95986-126   Fax: +49 (681)  95986-526
> Get my public key from keyserver, KeyId: 0x7C9821CC
> Fingerprint 4138 E617 E62E 79D3 E663 BE5A 14E7 1CD8 7C98 21CC
> 
> Vorstand: Ammar Alkassar (Vors.), Christian Stueble
> Vorsitzender des Aufsichtsrates: Prof. Dr. Kai Rannenberg
> Sitz der Gesellschaft: Homburg/Saar, HRB 3857 Amtsgericht Saarbruecken
> 
> This message may contain confidential and/or privileged information.
> If you are not the addressee, you must not use, copy, disclose or
> take any action based on this message or any information herein.
> If you have received this message in error, please advise the sender
> immediately by reply e-mail and delete this message.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/