linux-kernel - Re: [tip:x86/irq] x86: Always use irq stacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100714154746.GA2074@lst.de>
Date:	Wed, 14 Jul 2010 17:47:46 +0200
From:	Christoph Hellwig <hch@....de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Christoph Hellwig <hch@....de>, Ingo Molnar <mingo@...e.hu>,
	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	linux-tip-commits@...r.kernel.org, rostedt@...dmis.org
Subject: Re: [tip:x86/irq] x86: Always use irq stacks

On Wed, Jul 14, 2010 at 05:27:01PM +0200, Thomas Gleixner wrote:
> On Wed, 14 Jul 2010, Christoph Hellwig wrote:
> 
> > Turns out this wasn't a regression introduced by a commit, but it
> > happens when CONFIG_FUNCTION_GRAPH_TRACER is enabled.  From a quick
> > look I have no idea why these would interact badly, especially as
> > CONFIG_FUNCTION_GRAPH_TRACER works fine with irq stacks if the
> > CONFIG_4KSTACKS options is set.
> 
> So you're saying, that the problem appears when
> CONFIG_FUNCTION_GRAPH_TRACER is enabled w/o being used and that it
> exists prior to your patches with irq stacks and 8k stack size, but
> works with 4k stacks. That's definitely more than odd.

No, the problem does not show up with 8k stack size without irqstacks,
and does not show up with 4k stacks with irq stacks, but does show up
with 8k stacks with irqstacks as long as CONFIG_FUNCTION_GRAPH_TRACER is
enabled. Just disabling it in Ingo's example config makes it work,
and enabling it in my usual test configs makes the boot fail with
similar messages to the one Ingo sees.

> 
> Thanks,
> 
> 	tglx
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/