linux-kernel - Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to terminate statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1279146149.5816.53.camel@Joe-Laptop.home>
Date:	Wed, 14 Jul 2010 15:22:29 -0700
From:	Joe Perches <joe@...ches.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	x86 <x86@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to
 terminate statements

On Thu, 2010-07-15 at 00:00 +0200, Thomas Gleixner wrote:
> On Wed, 14 Jul 2010, Joe Perches wrote:
> that's one of the most convoluted changelogs I ever saw. 
> > These are the only "," terminated statements that
> > precede a pr_<level> in the kernel tree.
> Terminating a statement with a comma is simply wrong by itself and it
> needs to be fixed w/o further ado.

Great.  So remove the changelog and just use the subject.

I sent a simpler changelog patch last month.
http://lkml.org/lkml/2010/6/28/349

Ingo rejected it.

He said there were other style problems in the file that
needed cleaning.  I asked what those style problems were.
checkpatch and his "code-quality" script don't show
significant issues.  No reply from Ingo.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/