linux-kernel - Re: [PATCH] rtc-isl12022: properly handle military hour format

Open Source and information security mailing list archives

Message-ID: <AANLkTilkyIHdtwSAgbp2sr84PRblmiGwRw8NxglKnJa7@mail.gmail.com>
Date:	Wed, 14 Jul 2010 14:54:39 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Roman Fietze <roman.fietze@...emotive.de>
Cc:	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc-isl12022: properly handle military hour format

2010/7/14 Roman Fietze <roman.fietze@...emotive.de>:
> Hello Wan, hello list members,
>
> I found a bug in my rtc-isl12022. Seems I missed to test that driver
> thoroughly in the afternoons.

It's not very helpful to only say "I found a bug in ". What was wrong
with the old code missed some flags?
But I give you my ack, since I believe it is really wrong, you should
know more this hardware register than me.:)

Acked-by: Wan ZongShun <mcuos.com@...il.com>

>
> From 151b7d5413e189ec8f6dd578c253500d8814128e Mon Sep 17 00:00:00 2001
> From: Roman Fietze <roman.fietze@...emotive.de>
> Date: Wed, 14 Jul 2010 07:32:49 +0200
> Subject: [PATCH] rtc-isl12022: properly handle military hour format
>
> Mask out PM flag when reading the hour, always set MIL bit when
> writing the hour.
>
> Signed-off-by: Roman Fietze <roman.fietze@...emotive.de>
> ---
>  drivers/rtc/rtc-isl12022.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c
> index 293d2c1..0f300b4 100644
> --- a/drivers/rtc/rtc-isl12022.c
> +++ b/drivers/rtc/rtc-isl12022.c
> @@ -126,7 +126,7 @@ static int isl12022_get_datetime(struct i2c_client
> *client, struct rtc_time *tm)
>
>        tm->tm_sec = bcd2bin(buf[ISL12022_REG_SC] & 0x7F);
>        tm->tm_min = bcd2bin(buf[ISL12022_REG_MN] & 0x7F);
> -       tm->tm_hour = bcd2bin(buf[ISL12022_REG_HR] & 0x3F);
> +       tm->tm_hour = bcd2bin(buf[ISL12022_REG_HR] & 0x1F);
>        tm->tm_mday = bcd2bin(buf[ISL12022_REG_DT] & 0x3F);
>        tm->tm_wday = buf[ISL12022_REG_DW] & 0x07;
>        tm->tm_mon = bcd2bin(buf[ISL12022_REG_MO] & 0x1F) - 1;
> @@ -192,7 +192,7 @@ static int isl12022_set_datetime(struct i2c_client
> *client, struct rtc_time *tm)
>        /* hours, minutes and seconds */
>        buf[ISL12022_REG_SC] = bin2bcd(tm->tm_sec);
>        buf[ISL12022_REG_MN] = bin2bcd(tm->tm_min);
> -       buf[ISL12022_REG_HR] = bin2bcd(tm->tm_hour);
> +       buf[ISL12022_REG_HR] = bin2bcd(tm->tm_hour) | ISL12022_HR_MIL;
>
>        buf[ISL12022_REG_DT] = bin2bcd(tm->tm_mday);
>
> --
> 1.7.1
>
>
> --
> Roman Fietze              Telemotive AG Buero Muehlhausen
> Breitwiesen                             73347 Muehlhausen
> Tel.: +49(0)7335/18493-45        http://www.telemotive.de
>

-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives