linux-kernel - Re: [PATCH 2/12] ak4642: fix a memory leak if failed to initialise AK4642

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <w3p4og1mgt3.wl%kuninori.morimoto.gx@renesas.com>
Date:	Thu, 15 Jul 2010 14:53:45 +0900 (JST)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Tejun Heo <tj@...nel.org>, alsa-devel@...a-project.org
Subject: Re: [PATCH 2/12] ak4642: fix a memory leak if failed to initialise
	AK4642


Dear Axel

Thanks about this patch

> --- a/sound/soc/codecs/ak4642.c
> +++ b/sound/soc/codecs/ak4642.c
> @@ -491,8 +491,10 @@ static int ak4642_i2c_probe(struct i2c_client *i2c,
>  	codec->control_data = i2c;
>  
>  	ret = ak4642_init(ak4642);
> -	if (ret < 0)
> +	if (ret < 0) {
>  		printk(KERN_ERR "failed to initialise AK4642\n");
> +		kfree(ak4642);
> +	}
>  
>  	return ret;
>  }

Indeed. this operation is needed when error case.

I think
i2c_set_clientdata(i2c, NULL); is needed here too.
(da7210 also)

And why ak4642's patch doesn't have
snd_soc_unregister_codec fix like da7210 ?
I think ak4642 have same issue

Best regards
--
Kuninori Morimoto
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/