| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1279176147-5521-1-git-send-email-segooon@gmail.com> Date: Thu, 15 Jul 2010 10:42:27 +0400 From: Kulikov Vasiliy <segooon@...il.com> To: kernel-janitors@...r.kernel.org Cc: Andrew Morton <akpm@...ux-foundation.org>, Julia Lawall <julia@...u.dk>, Tejun Heo <tj@...nel.org>, Jiri Kosina <jkosina@...e.cz>, Dan Carpenter <error27@...il.com>, linux-kernel@...r.kernel.org Subject: [PATCH 1/2] i2o: fix overflow of copy_to_user() If (len > reslen) we must not call copy_to_user() since kernel buffer is smaller than we want to copy. Similar code in this file is correct, so this bug was a typo. Signed-off-by: Kulikov Vasiliy <segooon@...il.com> --- drivers/message/i2o/i2o_config.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c index c4b117f..4dd39a0 100644 --- a/drivers/message/i2o/i2o_config.c +++ b/drivers/message/i2o/i2o_config.c @@ -115,7 +115,7 @@ static int i2o_cfg_gethrt(unsigned long arg) put_user(len, kcmd.reslen); if (len > reslen) ret = -ENOBUFS; - if (copy_to_user(kcmd.resbuf, (void *)hrt, len)) + else if (copy_to_user(kcmd.resbuf, (void *)hrt, len)) ret = -EFAULT; return ret; -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists