linux-kernel - Re: [rtc-linux] [PATCH] Fix the rx8581 setdatetime

Open Source and information security mailing list archives

Message-ID: <AANLkTinM2NZ1Bx_ONyPYZ37GlKjmtk3bjFNQfktlCOGJ@mail.gmail.com>
Date:	Thu, 15 Jul 2010 17:45:09 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	linux-rtc <rtc-linux@...glegroups.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Martyn Welch <martyn.welch@...anuc.com>
Subject: Re: [rtc-linux] [PATCH] Fix the rx8581 setdatetime

2010/7/15 Rudolf Marek <rudolf.marek@...go.com>:
> Hello,
>
> This patch fixes the logic while writing new date/time to the chip. The
> driver incorrectly written back register values to different registers
> and even with wrong mask. The patch adds clearing of the VLF register,
> which should be cleared if all date/time values are set.
>
> Signed-off-by: Rudolf Marek <rudolf.marek@...go.com>
>
> I'm attaching this as an attachment because Thunderbird will break it

Not everyone has time and willing to download your patch for reviewing,
so why not try to setting your Thunderbird to solve this break?

Anyway, this is a good patch, thanks!

Acked-by: Wan ZongShun <mcuos.com@...il.com>

> otherwise.
> For your reference, datasheet is here:
>
> http://www.epsontoyocom.co.jp/english/product/RTC/set03/ra8581sa/index.html
>
> Thanks,
> Rudolf
>
> --
>
> S přátelským pozdravem / Best regards / Mit freundlichen Grüßen
>
> Ing. Rudolf Marek
> SYSGO s.r.o.
> Zelený pruh 99
> CZ-14800 Praha 4
> Phone: +420 222138 627, +49 6136 9948 627
> Fax: +420 296374890, +49 6136 9948 1 627
> rudolf.marek@...go.com
>
> http://www.sysgo.com | http://www.elinos.com | http://www.pikeos.com
>
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
>

-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives