linux-kernel - Re: emacs and "linux" coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1007151432460.1500@localhost.localdomain>
Date:	Thu, 15 Jul 2010 14:46:48 +0300 (EEST)
From:	Dimitrios Apostolou <jimis@....net>
To:	Theodore Tso <tytso@....EDU>
cc:	Randy Dunlap <rdunlap@...otime.net>, linux-kernel@...r.kernel.org,
	Dan Nicolaescu <dann@....org>, Teemu Likonen <tlikonen@....fi>
Subject: Re: emacs and "linux" coding style

Hi,

On Wed, 14 Jul 2010, Theodore Tso wrote:
> I've always read indentation as referring to indentation for the beginning of
> code lines, but not to making function parameters or paraenthesis line
> up.   This is something which emacs does automatically, but vi does not.
>
> People who are anal enough to worry about this sort of thing, in general,
> IMHO, really should find better things to do.   And if checkpatch.pl were to
> be "improved" to start issue warnings about code not adhering to this
> CodingStyle assertion, #1, you would find out how much code doesn't
> adhere to this, and #2, I think a lot of people, including myself, would be
> complaining vociferously and agitating to have that language removed
> from CodingStyle as being an actively harmful and incorrect recommendation.

if two kernel developers agree that tabs-only alignment of arglists is not 
necessary, then my guess is that the CodingStyle document is broken and 
needs to be fixed. Quote from Documentation/CodingStyle:

That's OK, we all do.  You've probably been told by your long-time 
Unix user helper that "GNU emacs" automatically formats the C sources for 
you, and you've noticed that yes, it does do that, but the defaults it 
uses are less than desirable (in fact, they are worse than random typing - 
an infinite number of monkeys typing into GNU emacs would never make a 
good program).

So, you can either get rid of GNU emacs, or change it to use saner
values.  To do the latter, you can stick the following in your .emacs 
file:

If emacs' style is OK then why all this inflamatory talk is needed, and 
why is a patch proposed? The only thing needed is to use the "linux" 
c-style.

Thanks,
Dimitris

P.S. CC'd the author of latest emacs-related patch in CodingStyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/