linux-kernel - Re: [PATCH 1/2] xfs: don't block on buffer read errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100715000552.GE30737@dastard>
Date:	Thu, 15 Jul 2010 10:05:52 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	xfs@....sgi.com, axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] xfs: don't block on buffer read errors

On Wed, Jul 14, 2010 at 02:28:36PM -0400, Christoph Hellwig wrote:
> Looks good, except that I'd rework the snipplet below
> 
> >  	status = xfs_buf_iorequest(bp);
> > -	if (!status && !(flags & XBF_ASYNC))
> > +	if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
> >  		status = xfs_buf_iowait(bp);
> >  	return status;
> 
> as:
> 
> 	if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
> 		return status;
> 	return xfs_buf_iowait(bp);
> 
> to make it a bit more clear.

Make sense. Fixed it up.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/