linux-kernel - Re: [PATCH] blkdev: cgroup whitelist permission fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100715155415.GU14017@sequoia.sous-sol.org>
Date:	Thu, 15 Jul 2010 08:54:15 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	"Serge E. Hallyn" <serge.hallyn@...onical.com>,
	Christoph Hellwig <hch@...radead.org>,
	"Daniel P. Berrange" <berrange@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blkdev: cgroup whitelist permission fix

* Chris Wright (chrisw@...s-sol.org) wrote:
> The cgroup device whitelist code gets confused when trying to grant
> permission to a disk partition that is not currently open.  Part of
> blkdev_open() includes __blkdev_get() on the whole disk.  This simply
> avoids the cgroup check for the whole disk case when opening a
> partition.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=589662
> 
> Acked-by: Serge E. Hallyn <serue@...ibm.com>
> Tested-by: Serge E. Hallyn <serue@...ibm.com>
> Signed-off-by: Chris Wright <chrisw@...s-sol.org>

Andrew, plans to push this on?  Christoph doesn't like the whole of
blockdev whitelisting for good reason, but it's currently in use and
has this bug.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/