linux-kernel - Re: Bugzilla # 16395: Regression in 2.6.35-rc4 since commit 0b28bac5aef7bd1ab213723df031e61db9ff151a on HP Mini 110 Netbook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C3E59CD.7050901@lwfinger.net>
Date:	Wed, 14 Jul 2010 19:43:57 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Bugzilla # 16395: Regression in 2.6.35-rc4 since commit 0b28bac5aef7bd1ab213723df031e61db9ff151a
 on HP Mini 110 Netbook

On 07/14/2010 07:07 PM, Dmitry Torokhov wrote:
> On Wednesday, July 14, 2010 04:58:39 pm Larry Finger wrote:
>> Since the commit in the title, a kernel built on an HP Mini 110 Netbook no
>> longer has keyboard input. The main difference is that CONFIG_SERIO_I8042
>> is no longer defined. When this equal yes, the keyboard works. The faulty
>> commit was located by bisection and has been verified by reverting the
>> patch.
>>
>> Further investigation shows that the faulty hunk is
>>
>> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
>> index 3bfe8fa..256b9e9 100644
>> --- a/drivers/input/serio/Kconfig
>> +++ b/drivers/input/serio/Kconfig
>> @@ -22,7 +22,7 @@ config SERIO_I8042
>>           tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
>>           default y
>>           depends on !PARISC&&  (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST)&&  \
>> -                  (!SUPERH || SH_CAYMAN)&&  !M68K&&  !BLACKFIN
>> +                  (!SUPERH || SH_CYes, AYMAN)&&  !M68K&&  !BLACKFIN&&
>> !X86_MRST help
>>             i8042 is the chip over which the standard AT keyboard and PS/2
>>             mouse are connected to the computer. If you use these devices,
>>
>> Reverting this one hunk alone results in a working system. Obviously, this
>> Netbook does not have X86_MRST set.
>
>
> You meant to say "does have CONFIG_X86_MRST set", right?

Yes. I got lost in the negative logic. Since !X86_MRST is false, then X86_MRST 
has to be defined. In fact, .config has CONFIG_X86_MRST=y.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/