linux-kernel - Re: [PATCH][securityfs][2.6.34] Drop dentry reference count when mknod fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100715171051.GA21798@kroah.com>
Date:	Thu, 15 Jul 2010 10:10:51 -0700
From:	Greg KH <greg@...ah.com>
To:	Tvrtko Ursulin <tvrtko.ursulin@...hos.com>
Cc:	James Morris <jmorris@...ei.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH][securityfs][2.6.34] Drop dentry reference count when
	mknod fails

On Thu, Jul 15, 2010 at 01:25:06PM +0100, Tvrtko Ursulin wrote:
> 
> lookup_one_len increments dentry reference count which is not decremented
> when the create operation fails. This can cause a kernel BUG at
> fs/dcache.c:676 at unmount time. Also error code returned when new_inode()
> fails was replaced with more appropriate -ENOMEM.
> 

Nice, thanks for finding and fixing this, great job.

> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@...hos.com>

Acked-by: Greg Kroah-Hartman <gregkh@...e.de>

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/