linux-kernel - Re: [PATCH] twl6040: fix wrong kfree in twl6040_remove and twl6040_codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100716093625.GD18376@sirena.org.uk>
Date:	Fri, 16 Jul 2010 10:36:25 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Margarita Olaya Cabrera <magi.olaya@...com>,
	Jorge Eduardo Candelaria <jorge.candelaria@...com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] twl6040: fix wrong kfree in twl6040_remove and
	twl6040_codec_remove

On Fri, Jul 16, 2010 at 05:26:48PM +0800, Axel Lin wrote:
> Memory allocation part:
> We allocate a memory in twl6040_codec_probe():
>         priv = kzalloc(sizeof(struct twl6040_data), GFP_KERNEL);
>         twl6040_codec = codec = &priv->codec;

Could you please try to take on board the feedback you were given
yesterday about this sort of stuff?  Both the feedback about formatting
your patch so it's easy to apply and the collisions with other, more
substantial, work that's going on?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/