linux-kernel - Re: [PATCH 1/2] Remove REDWOOD_[456] config options and conditional code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <redwood56-reply-2-miltonm@bga.com>
Date:	Fri, 16 Jul 2010 10:45:27 -0500
From:	Milton Miller <miltonm@....com>
To:	Christian Dietrich <qy03fugy@...d.informatik.uni-erlangen.de>
Cc:	Milton Miller <miltonm@....com>,
	Josh Boyer <jwboyer@...ux.vnet.ibm.com>,
	Matt Porter <mporter@...nel.crashing.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Solomon Peachy <solomon@...ux-wlan.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Mike Frysinger <vapier@...too.org>,
	Jiri Kosina <jkosina@...e.cz>,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>,
	Alexander Kurz <linux@...babel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	John Linn <john.linn@...inx.com>,
	Florian Fainelli <florian@...nwrt.org>,
	Nicolas Pitre <nico@...xnic.net>,
	Joe Perches <joe@...ches.com>,
	Ladislav Michl <ladis@...ux-mips.org>,
	David Brown <davidb@...cinc.com>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	netdev@...r.kernel.org, vamos-dev@...informatik.uni-erlangen.de
Subject: Re: [PATCH 1/2] Remove REDWOOD_[456] config options and conditional code


On Fri, 16 Jul 2010 at about 08:20:55 -0600 Josh Boyer wrote:
> On Fri, Jul 16, 2010 at 02:29:02PM +0200, Christian Dietrich wrote: 
> > The config options for REDWOOD_[456] were commented out in the powerpc
> > Kconfig. The ifdefs referencing this options therefore are dead and all
> > references to this can be removed (Also dependencies in other KConfig
> > files).

> This seems fine with me.
> 
> The only question is which tree it coms through. I'm happy to take it
> in via mine if the netdev and MTD people are fine with that. Otherwise,
> my ack is below.


> On Fri, 16 Jul 2010 around 14:29:08 +0200 Christian Dietrich wrote:
> > diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
> > index f22bc9f..6629d09 100644
> > --- a/drivers/mtd/maps/Kconfig
> > +++ b/drivers/mtd/maps/Kconfig
> > @@ -321,7 +321,7 @@ config MTD_CFI_FLAGADM
> > 
> >  config MTD_REDWOOD
> >  	tristate "CFI Flash devices mapped on IBM Redwood"
> > -	depends on MTD_CFI && ( REDWOOD_4 || REDWOOD_5 || REDWOOD_6 )
> > +	depends on MTD_CFI
> >  	help
> >  	  This enables access routines for the flash chips on the IBM
> >  	  Redwood board. If you have one of these boards and would like to
> > diff --git a/drivers/mtd/maps/redwood.c b/drivers/mtd/maps/redwood.c
> > index 933c0b6..d2c9db0 100644
> > --- a/drivers/mtd/maps/redwood.c
> > +++ b/drivers/mtd/maps/redwood.c
> > @@ -22,8 +22,6 @@

The patches are unnecssarly coupled by removing the REDWOOD_* symbols
in the MTD area before removing the files and Kconfig completely in
the second patch.  This could easily be eliminated by pushing the
two fragments into the second patch.

milton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/