linux-kernel - Re: [PATCH] slob_free:free objects to their own list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikbGTlAPAj6lbuR5nIWyBAqnfBpy3IE_LywrPID@mail.gmail.com>
Date:	Fri, 16 Jul 2010 13:46:28 +0800
From:	Bob Liu <lliubbo@...il.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Matt Mackall <mpm@...enic.com>, akpm@...ux-foundation.org,
	linux-mm@...ck.org, hannes@...xchg.org,
	LKML <linux-kernel@...r.kernel.org>, Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH] slob_free:free objects to their own list

On Wed, Jul 14, 2010 at 5:07 PM, Pekka Enberg <penberg@...helsinki.fi> wrote:
> On Wed, Jul 14, 2010 at 12:53 AM, Matt Mackall <mpm@...enic.com> wrote:
>> On Tue, 2010-07-13 at 20:52 +0300, Pekka Enberg wrote:
>>> Hi Bob,
>>>
>>> [ Please CC me on SLOB patches. You can use the 'scripts/get_maintainer.pl'
>>>   script to figure out automatically who to CC on your patches. ]
>>>
>>> On Sat, Jul 10, 2010 at 1:05 PM, Bob Liu <lliubbo@...il.com> wrote:
>>> > slob has alloced smaller objects from their own list in reduce
>>> > overall external fragmentation and increase repeatability,
>>> > free to their own list also.
>>> >
>>> > Signed-off-by: Bob Liu <lliubbo@...il.com>
>>>
>>> The patch looks sane to me. Matt, does it look OK to you as well?
>>
>> Yep, this should be a marginal improvement.
>>
>> Acked-by: Matt Mackall <mpm@...enic.com>
>
> Great! Bob, if you could provide the /proc/meminfo numbers for the
> patch description, I'd be more than happy to merge this.
>
Hi, Pekka

Sorry for the wrong cc and later reply.
This is  /proc/meminfo result in my test machine:
without this patch:
===
MemTotal:        1030720 kB
MemFree:          750012 kB
Buffers:           15496 kB
Cached:           160396 kB
SwapCached:            0 kB
Active:           105024 kB
Inactive:         145604 kB
Active(anon):      74816 kB
Inactive(anon):     2180 kB
Active(file):      30208 kB
Inactive(file):   143424 kB
Unevictable:          16 kB
....

with this patch:
===
MemTotal:        1030720 kB
MemFree:          751908 kB
Buffers:           15492 kB
Cached:           160280 kB
SwapCached:            0 kB
Active:           102720 kB
Inactive:         146140 kB
Active(anon):      73168 kB
Inactive(anon):     2180 kB
Active(file):      29552 kB
Inactive(file):   143960 kB
Unevictable:          16 kB
...

The result show only very small improverment!
And when i tested it on a embeded system with 64MB, I found this path
is never called while kernel booting.

Thanks for the kindly review.

-- 
Regards,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/