lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Sat, 17 Jul 2010 12:26:08 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [patch] auditsc: audit_log_single_execve_arg() returns signed

"len" needs to be signed because audit_log_single_execve_arg() returns
-1 and we want to check for that:

                len = audit_log_single_execve_arg(context, ab, i,
                                                  &len_sent, p, buf);
                if (len <= 0)
                        break;

Signed-off-by: Dan Carpenter <error27@...il.com>

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 3828ad5..2c060c3 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1158,7 +1158,8 @@ static void audit_log_execve_info(struct audit_context *context,
 				  struct audit_aux_data_execve *axi)
 {
 	int i;
-	size_t len, len_sent = 0;
+	ssize_t len;
+	size_t len_sent = 0;
 	const char __user *p;
 	char *buf;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists