linux-kernel - Re: [PATCH[RFC] Quirk macbook pro 6,2 into ahci mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jul 2010 19:42:43 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>, jgarzik@...ox.com,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH[RFC] Quirk macbook pro 6,2 into ahci mode

On Sun, Jul 18, 2010 at 10:03:44AM -0600, Jens Axboe wrote:

> So while the below works, it doesn't work when the laptop is
> coming out of suspend. I can't seem to find out why, since it's
> a bit hard to debug when you are on the road. What happens is
> that it comes back with a bit of a delay, and then the disks are
> apparently gone. I've tried adding a resume quirk to re-AHCI the
> thing, but it doesn't help.

You'll certainly need to re-quirk on resume, since there's no guarantee 
that the firmware will do it for you. My suspicion is that it comes up 
in PATA mode with legacy firmware in order to improve compatibility with 
XP, and you'd have ahci if you booted through EFI. I don't have 
something handy to test that right now, though.

> Looking at the specs, I don't see what I am missing to make this
> work for resume. I'm assuming that EFI did initialize some bits
> that am missing when coming out of resume, but I don't know which
> bits.

There's no guarantee that the AHCI BAR is programmed by the firmware (it 
seems to be on the Macs, but won't be on most hardware). Is it getting 
reprogrammed on resume?

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/