linux-kernel - Re: emacs and "linux" coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100718071552.GB4684@thunk.org>
Date:	Sun, 18 Jul 2010 03:15:52 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Krzysztof Halasa <khc@...waw.pl>,
	Dimitrios Apostolou <jimis@....net>,
	linux-kernel@...r.kernel.org, Dan Nicolaescu <dann@....org>
Subject: Re: emacs and "linux" coding style

On Sat, Jul 17, 2010 at 06:51:46AM -0700, Randy Dunlap wrote:
> On Sat, 17 Jul 2010 11:21:03 +0200 Krzysztof Halasa wrote:
> 
> > Dimitrios Apostolou <jimis@....net> writes:
> > 
> > > static void update_group_shares_cpu(struct task_group *tg, int cpu,
> > >                                     unsigned long sd_shares,
> > >                                     unsigned long sd_rq_weight,
> > >                                     unsigned long *usd_rq_weight)
> > > {
> > 
> > From a technical POV the above should not have any tabs, the parameters
> > should be aligned with spaces only.
> 
> fwiw, it seems that you agree with Ted.

Actually, what my code use is tabs with a tab stop of 8 followed by
enough spaces (< 7) to align function parameters and to align
open/close parenthesis in C expression line wrap.

The main problem seems to be that Chapter 9 in
Documentation/CodingStyle is written by someone who feels that since
vi makes it easy to only align parameters using tabs, that everybody
should do it the same way as vi.  I'm simply challenging Chapter 9 as
being canon.  I certainly ignore it, and as a maintainer I tend to
accept either vi or emacs-style indentations with respect to
parameters and C expressions.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/