linux-kernel - Re: [PATCH 7/8] Use xvmalloc to store compressed chunks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C42B2E4.4040504@cs.helsinki.fi>
Date:	Sun, 18 Jul 2010 10:53:08 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Nitin Gupta <ngupta@...are.org>
CC:	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Rik van Riel <riel@...hat.com>, Avi Kivity <avi@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	Minchan Kim <minchan.kim@...il.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	linux-mm <linux-mm@...ck.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/8] Use xvmalloc to store compressed chunks

Nitin Gupta wrote:
> @@ -528,17 +581,32 @@ static int zcache_store_page(struct zcache_inode_rb *znode,
>  		goto out;
>  	}
>  
> -	dest_data = kmap_atomic(zpage, KM_USER0);
> +	local_irq_save(flags);

Does xv_malloc() required interrupts to be disabled? If so, why doesn't 
the function do it by itself?

> +	ret = xv_malloc(zpool->xv_pool, clen + sizeof(*zheader),
> +			&zpage, &zoffset, GFP_NOWAIT);
> +	local_irq_restore(flags);
> +	if (unlikely(ret)) {
> +		ret = -ENOMEM;
> +		preempt_enable();
> +		goto out;
> +	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/