lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 18 Jul 2010 13:51:34 +0530
From:	Nitin Gupta <>
To:	Pekka Enberg <>
CC:	Hugh Dickins <>,
	Andrew Morton <>,
	Greg KH <>,
	Dan Magenheimer <>,
	Rik van Riel <>, Avi Kivity <>,
	Christoph Hellwig <>,
	Minchan Kim <>,
	Konrad Rzeszutek Wilk <>,
	linux-mm <>,
	linux-kernel <>
Subject: Re: [PATCH 7/8] Use xvmalloc to store compressed chunks

On 07/18/2010 01:23 PM, Pekka Enberg wrote:
> Nitin Gupta wrote:
>> @@ -528,17 +581,32 @@ static int zcache_store_page(struct zcache_inode_rb *znode,
>>          goto out;
>>      }
>> -    dest_data = kmap_atomic(zpage, KM_USER0);
>> +    local_irq_save(flags);
> Does xv_malloc() required interrupts to be disabled? If so, why doesn't the function do it by itself?

xvmalloc itself doesn't require disabling interrupts but zcache needs that since
otherwise, we can have deadlock between xvmalloc pool lock and mapping->tree_lock
which zcache_put_page() is called. OTOH, zram does not require this disabling of
interrupts. So, interrupts are disable separately for zcache case.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists