lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Jul 2010 16:58:51 +0200 From: Christoph Hellwig <hch@....de> To: Lubomir Rintel <lkundrak@...sk> Cc: Christoph Hellwig <hch@....de>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 filesystems On Mon, Jul 19, 2010 at 07:16:42PM +0200, Lubomir Rintel wrote: > A mount-time option was added that makes it possible to override the > endianness and an attempt is made to autodetect it (which seems easy, > given the disk addresses are 3-byte. > > No attempt is made to detect big-endian filesystems -- were there any? > Tested with PDP-11 v7 filesystems and PC-IX maintenance floppy. Do you actually need the mount option? We get away just fine with it for sysv filesystems. And if not I'd be consistent and accept the options for both sysv and v7 filesystems. > + /* plausibility check on root inode: it is a directory, > + with a nonzero size that is a multiple of 16 */ > + if ((bh2 = sb_bread(sb, 2)) == NULL) { > + return 0; > + } A little style nitpick, this should be: bh2 = sb_bread(sb, 2); if (!bh) return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists