linux-kernel - Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <590491.14987.qm@web180309.mail.gq1.yahoo.com>
Date:	Mon, 19 Jul 2010 03:08:36 -0700 (PDT)
From:	David Brownell <david-b@...bell.net>
To:	Greg KH <greg@...ah.com>,
	Michał Nazarewicz <m.nazarewicz@...sung.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Alan Stern <stern@...land.harvard.edu>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>,
	stable <stable@...nel.org>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number


>   It in no way duplicates functionality of
> the composite layer.

Beyond the obvious "Set serial number" ...


> As a matter of fact, without
> this patch, the
> iSerialNumber module parameter won't work

So submit a bugfix for that alone, making it
work everywhere... 

> (not tested, just looked at the code).

Do you know when it broke?  That code has been
tested in the past, and observed to work.  So if
it's not working now, someone broke it and that
should just be fixed.



> The second patch (by Yann Cantin) adds a serial module
> parameter to
> the File Storage Gadget.  FSG is not a composite
> gadget 

OK, so it should add a module param with the same
name as used elsewhere ... makes sense to me.  If
Alan Acks that patch, go for it.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/