linux-kernel - Re: [PATCH repost] pci: fix compilation when CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100719104202.GA32031@redhat.com>
Date:	Mon, 19 Jul 2010 13:42:02 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	vgoyal@...hat.com, "David S. Miller" <davem@...emloft.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>, seto.hidetoshi@...fujitsu.com,
	Matt Carlson <mcarlson@...adcom.com>,
	Michael Chan <mchan@...adcom.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH repost] pci: fix compilation when CONFIG_PCI_MSI=n

On Fri, Jul 16, 2010 at 12:06:03PM -0700, Jesse Barnes wrote:
> On Fri, 16 Jul 2010 17:20:50 +0300
> "Michael S. Tsirkin" <mst@...hat.com> wrote:
> 
> > vers/pci/pci.c:2277: error: redefinition of ‘pci_msi_off’
> > include/linux/pci.h:786: note: previous definition of ‘pci_msi_off’ was here
> > 
> > No need for ifdef: we must disable the capability at startup even if the
> > current kernel does not support MSI, otherwise the device won't work.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> > ---
> > 
> > Looks like I didn't tag this old patch of mine clearly enough
> > so it's still not fixed in -rc5.
> > It's late in the cycle, but the patch is trivial
> > and it's a build fix, so ... please consider for 2.6.35.
> 
> I don't see the same context in the current tree.  So this patch must
> be against the virtualization tree I guess?

Yes, looks like it got fixed in the virtualization tree.
Thanks,
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/