linux-kernel - Re: [PATCH 09/18] xstat: Make special system filesystems return FS_SPECIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8426.1279548573@redhat.com>
Date:	Mon, 19 Jul 2010 15:09:33 +0100
From:	David Howells <dhowells@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	dhowells@...hat.com, viro@...IV.linux.org.uk,
	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
	samba-technical@...ts.samba.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 09/18] xstat: Make special system filesystems return FS_SPECIAL_FL [ver #6]

Christoph Hellwig <hch@...radead.org> wrote:

> special is not a very useful identifier.  Also what you are returning
> is per-filesystem data, not per-file.  This needs to go into statfs,
> not into stat.  We're about to introduce flags for statfs, so try
> to do it ontop of those.
> 
> The same thing applies to the remote flag in the next patch.

Which means that you have to do two calls (xstat+statfs) to find this
information that we can return pretty much for free here, though you can cache
it based on st_dev, I suppose.

Also, not all the flags are per-filesystem.  The following are:

	FS_SPECIAL_FL		/* Special file as found in procfs/sysfs */
	FS_REMOTE_FL		/* File is remote */

but the rest aren't:

	FS_AUTOMOUNT_FL		/* Specific automount point */
	FS_AUTOMOUNT_ANY_FL	/* Unspecific automount directory */
	FS_ENCRYPTED_FL		/* File is encrypted */
	FS_HIDDEN_FL		/* File is marked hidden (DOS+) */
	FS_SYSTEM_FL		/* File is marked system (DOS+) */
	FS_ARCHIVE_FL		/* File is marked archive (DOS+) */
	FS_TEMPORARY_FL		/* File is temporary (NTFS/CIFS) */
	FS_OFFLINE_FL		/* File is offline (CIFS) */
	FS_REPARSE_POINT_FL	/* Reparse point (NTFS/CIFS) */

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/