linux-kernel - Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1007191017400.1657-100000@iolanthe.rowland.org>
Date:	Mon, 19 Jul 2010 10:19:06 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michał Nazarewicz <m.nazarewicz@...sung.com>
cc:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	<linux-kernel@...r.kernel.org>,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@...imo.com>,
	stable <stable@...nel.org>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

On Mon, 19 Jul 2010, [utf-8] MichaÅ Nazarewicz wrote:

> >> The second patch (by Yann Cantin) adds a serial module
> >> parameter to
> >> the File Storage Gadget.  FSG is not a composite
> >> gadget
> 
> > OK, so it should add a module param with the same
> > name as used elsewhere ...
> 
> I was going to propose that but file storage gadget uses names
> different from composite anyway (ie. vendor and product instead of
> idVendor and idProduct) so I dunno if it's worth it.  As a matter
> of fact, "serial" seems to match the other names better.
> 
> > makes sense to me.  I Alan Acks that patch, go for it.
> 
> I believe Alan already agreed on this patch.  I'm merely updating
> it to use the changes introduced by my patch to mass storage and
> g_multi.

I have lost track of the current state of that patch.  When you finish
updating it, please post it for my review.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/